Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mod] 각종 이슈 해결 (마이페이지 스크롤뷰, 버튼 ripple 제거, 상세페이지 이미지 문제 해결) #58

Merged
merged 7 commits into from
Jul 20, 2023
Merged

[mod] 각종 이슈 해결 (마이페이지 스크롤뷰, 버튼 ripple 제거, 상세페이지 이미지 문제 해결) #58

merged 7 commits into from
Jul 20, 2023

Conversation

jihyunniiii
Copy link
Collaborator

@jihyunniiii jihyunniiii commented Jul 20, 2023 •
edited
Loading

Related issue 🛠

Work Description ✏️

  • 마이페이지 스크롤뷰로 변경
  • 회원가입 버튼 ripple 제거

Screenshot 📸

Screen_Recording_20230721_013746.1.mp4

Uncompleted Tasks 😅

  • 상세페이지 이미지 안 뜨는 문제 해결

To Reviewers 📢

안빵이들아 수고했다 ㅋ.ㅋ

@jooyyoo jooyyoo added this to the api 연동 작업 milestone Jul 20, 2023
@jihyunniiii jihyunniiii changed the title [mod] 각종 이슈 해결 (마이페이지 스크롤뷰, 버튼 ripple 제거, 역 관련 칩 이슈, 상세페이지 이미지 문제 해결) [mod] 각종 이슈 해결 (마이페이지 스크롤뷰, 버튼 ripple 제거, 상세페이지 이미지 문제 해결) Jul 20, 2023
@jooyyoo jooyyoo requested review from jooyyoo and Dan2dani July 20, 2023 16:23
jooyyoo
jooyyoo approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@jooyyoo jooyyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지현이 최고~ 사랑해열 💟

@jihyunniiii jihyunniiii merged commit 5191558 into develop Jul 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jooyyoo jooyyoo jooyyoo approved these changes

@Dan2dani Dan2dani Awaiting requested review from Dan2dani

Assignees

@jihyunniiii jihyunniiii

Labels
🐸 지현 🐸 🔮mod 🔮
Projects
GEON_PPANG_AOS
Status: Done
Milestone
api 연동 작업
2 participants
@jihyunniiii @jooyyoo